| Summary: | [GStreamer] Convert GLVideoSink and WebKitWebSrc to WEBKIT_DEFINE_TYPE | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=204673 | ||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2019-11-28 03:11:37 PST
Created attachment 384446 [details]
Patch
Comment on attachment 384446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384446&action=review > Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:78 > + GST_DEBUG_CATEGORY_INIT(webkit_gl_video_sink_debug, "webkitglvideosink", 0, "GL video sink element")); We don't need the ; > Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:121 > + GST_CALL_PARENT(G_OBJECT_CLASS, constructed, (object)); Do this at the beginning, in the case of constructed we want to construct the parent first. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:187 > +); We don't need the ; > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:273 > + GST_CALL_PARENT(G_OBJECT_CLASS, constructed, (object)); Same here, do this at the beginning. Created attachment 384447 [details]
Patch
Committed r252918: <https://trac.webkit.org/changeset/252918> |