Bug 204674

Summary: [GStreamer] Convert GLVideoSink and WebKitWebSrc to WEBKIT_DEFINE_TYPE
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204673
Attachments:
Description Flags
Patch
none
Patch none

Philippe Normand
Reported 2019-11-28 03:11:37 PST
.
Attachments
Patch (8.85 KB, patch)
2019-11-28 03:35 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (8.98 KB, patch)
2019-11-28 03:52 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2019-11-28 03:35:58 PST
Created attachment 384446 [details] Patch
Carlos Garcia Campos
Comment 2 2019-11-28 03:51:27 PST
Comment on attachment 384446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384446&action=review > Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:78 > + GST_DEBUG_CATEGORY_INIT(webkit_gl_video_sink_debug, "webkitglvideosink", 0, "GL video sink element")); We don't need the ; > Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:121 > + GST_CALL_PARENT(G_OBJECT_CLASS, constructed, (object)); Do this at the beginning, in the case of constructed we want to construct the parent first. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:187 > +); We don't need the ; > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:273 > + GST_CALL_PARENT(G_OBJECT_CLASS, constructed, (object)); Same here, do this at the beginning.
Philippe Normand
Comment 3 2019-11-28 03:52:41 PST
Created attachment 384447 [details] Patch
Philippe Normand
Comment 4 2019-11-28 04:52:57 PST
Committed r252918: <https://trac.webkit.org/changeset/252918>
Radar WebKit Bug Importer
Comment 5 2019-11-28 04:53:25 PST
<rdar://problem/57519310>
Note You need to log in before you can comment on or make changes to this bug.