Bug 204668

Summary:

Cache integer font metrics for performance

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, mmaxfield, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Antti Koivisto 2019-11-28 01:19:05 PST

Line layout uses integer metrics and queries them a lot. Avoid repeated rounding.

Comment 1 Antti Koivisto 2019-11-28 01:23:59 PST

Created attachment 384445 [details]
patch

Comment 2 zalan 2019-11-28 07:08:10 PST

Comment on attachment 384445 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384445&action=review

> Source/WebCore/ChangeLog:8
> +        Line layout uses integer metrics and queries them a lot. Avoid repeated rounding.

Eventually IFC (or any line layout system really) should call the float flavor and do proper snapping at the line level.

Comment 3 WebKit Commit Bot 2019-11-28 08:03:58 PST

Comment on attachment 384445 [details]
patch

Clearing flags on attachment: 384445

Committed r252927: <https://trac.webkit.org/changeset/252927>

Comment 4 WebKit Commit Bot 2019-11-28 08:04:00 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-11-28 08:04:28 PST

<rdar://problem/57521037>