Summary: | Remove ENABLE_KEYBOARD_CODE_ATTRIBUTE and ENABLE_KEYBOARD_KEY_ATTRIBUTE macros | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebCore Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, annulen, benjamin, cdumez, cmarcelo, dbates, don.olmstead, esprehn+autocc, ews-watchlist, gyuyoung.kim, jbedard, kangil.han, keith_miller, kondapallykalyan, mark.lam, msaboff, ross.kirsling, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Fujii Hironori
2019-11-27 23:55:35 PST
Created attachment 384439 [details]
Patch
Comment on attachment 384439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384439&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:289 > +ENABLE_MEDIA_STREAM_watchos = ENABLE_MEDIA_STREAM; > +ENABLE_MEDIA_STREAM_watchsimulator = ENABLE_MEDIA_STREAM; > +ENABLE_MEDIA_STREAM_appletvos = ENABLE_MEDIA_STREAM; > +ENABLE_MEDIA_STREAM_appletvsimulator = ENABLE_MEDIA_STREAM; Did you mean to add these four lines to each FeatureDefines.xcconfig? (In reply to Ross Kirsling from comment #2) > Comment on attachment 384439 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384439&action=review > > > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:289 > > +ENABLE_MEDIA_STREAM_watchos = ENABLE_MEDIA_STREAM; > > +ENABLE_MEDIA_STREAM_watchsimulator = ENABLE_MEDIA_STREAM; > > +ENABLE_MEDIA_STREAM_appletvos = ENABLE_MEDIA_STREAM; > > +ENABLE_MEDIA_STREAM_appletvsimulator = ENABLE_MEDIA_STREAM; > > Did you mean to add these four lines to each FeatureDefines.xcconfig? The person who modified the base FeatureDefines.xcconfig is supposed to run a script to sync them. These lines are in the TestWebKitAPI one. Yeah, I just ran sync-feature-defines script. But, I shouldn't add those lines. They are removed in Bug 204254. Very good catch! Thank you for saving me not to brake the watchOS and appleTV. Created attachment 384479 [details]
Patch for landing
Comment on attachment 384479 [details] Patch for landing Clearing flags on attachment: 384479 Committed r252936: <https://trac.webkit.org/changeset/252936> All reviewed patches have been landed. Closing bug. |