Bug 204666

Summary:

Remove ENABLE_KEYBOARD_CODE_ATTRIBUTE and ENABLE_KEYBOARD_KEY_ATTRIBUTE macros

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

WebCore Misc.

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, annulen, benjamin, cdumez, cmarcelo, dbates, don.olmstead, esprehn+autocc, ews-watchlist, gyuyoung.kim, jbedard, kangil.han, keith_miller, kondapallykalyan, mark.lam, msaboff, ross.kirsling, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	don.olmstead: review+
Patch for landing	none

Fujii Hironori

Reported 2019-11-27 23:55:35 PST

ENABLE_KEYBOARD_CODE_ATTRIBUTE and ENABLE_KEYBOARD_KEY_ATTRIBUTE macros are defined for all ports, remove them.

Attachments
Patch (74.40 KB, patch) 2019-11-28 00:01 PST, Fujii Hironori	don.olmstead: review+	Details Formatted Diff Diff
Patch for landing (70.78 KB, patch) 2019-11-28 21:49 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-11-28 00:01:47 PST

Created attachment 384439 [details] Patch

Ross Kirsling

Comment 2 2019-11-28 20:41:31 PST

Comment on attachment 384439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384439&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:289 > +ENABLE_MEDIA_STREAM_watchos = ENABLE_MEDIA_STREAM; > +ENABLE_MEDIA_STREAM_watchsimulator = ENABLE_MEDIA_STREAM; > +ENABLE_MEDIA_STREAM_appletvos = ENABLE_MEDIA_STREAM; > +ENABLE_MEDIA_STREAM_appletvsimulator = ENABLE_MEDIA_STREAM; Did you mean to add these four lines to each FeatureDefines.xcconfig?

Don Olmstead

Comment 3 2019-11-28 21:10:44 PST

(In reply to Ross Kirsling from comment #2) > Comment on attachment 384439 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384439&action=review > > > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:289 > > +ENABLE_MEDIA_STREAM_watchos = ENABLE_MEDIA_STREAM; > > +ENABLE_MEDIA_STREAM_watchsimulator = ENABLE_MEDIA_STREAM; > > +ENABLE_MEDIA_STREAM_appletvos = ENABLE_MEDIA_STREAM; > > +ENABLE_MEDIA_STREAM_appletvsimulator = ENABLE_MEDIA_STREAM; > > Did you mean to add these four lines to each FeatureDefines.xcconfig? The person who modified the base FeatureDefines.xcconfig is supposed to run a script to sync them. These lines are in the TestWebKitAPI one.

Fujii Hironori

Comment 4 2019-11-28 21:36:55 PST

Yeah, I just ran sync-feature-defines script. But, I shouldn't add those lines. They are removed in Bug 204254. Very good catch! Thank you for saving me not to brake the watchOS and appleTV.

Fujii Hironori

Comment 5 2019-11-28 21:49:43 PST

Created attachment 384479 [details] Patch for landing

Fujii Hironori

Comment 6 2019-11-28 22:55:02 PST

Comment on attachment 384479 [details] Patch for landing Clearing flags on attachment: 384479 Committed r252936: <https://trac.webkit.org/changeset/252936>

Fujii Hironori

Comment 7 2019-11-28 22:55:06 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-11-28 22:56:58 PST

<rdar://problem/57527964>

Note You need to log in before you can comment on or make changes to this bug.