Bug 204561 – [LFC][IFC] Construct only one LineLayout object per inline formatting context

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

and not one for each line.

[Radar WebKit Bug Importer]

<rdar://problem/57463666>

[alan]

Created attachment 384263 [details]
Patch

[Antti Koivisto]

Comment on attachment 384263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384263&action=review

> Source/WebCore/ChangeLog:9
> +        Let's construct only one LineLayout object per IFC.

I kinda liked that one object represents layout of one line. What do we gain from reusing it?

[alan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 384263 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384263&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Let's construct only one LineLayout object per IFC.
> 
> I kinda liked that one object represents layout of one line. What do we gain
> from reusing it?
What I am trying to achieve here is (and probably failing because of bad naming) to have something similar to what we do with the formatting contexts. In this setup the context is the LineLayout class. It is not a per-line-context but rather for the entire inline content. Let me find a better name for LineLayout and address it in a separate patch.

[alan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 384263 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384263&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Let's construct only one LineLayout object per IFC.
> 
> I kinda liked that one object represents layout of one line. What do we gain
> from reusing it?
Line (or as we discussed the LineBuilder) class represents the layout of one line.

[alan]

Committed r252861: <https://trac.webkit.org/changeset/252861>