Bug 204549

Summary: Reduce JSC's binary size
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ews-watchlist, gyuyoung.kim, jberlin, keith_miller, mark.lam, msaboff, rniwa, ryuan.choi, saam, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Tadeu Zagallo
Reported 2019-11-23 08:54:37 PST
...
Attachments
Patch (51.74 KB, patch)
2019-11-23 09:07 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch (52.56 KB, patch)
2019-11-23 09:46 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (53.00 KB, patch)
2019-12-10 10:56 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-11-23 09:07:25 PST
Created attachment 384238 [details] Patch
Tadeu Zagallo
Comment 2 2019-11-23 09:46:13 PST
Created attachment 384239 [details] Patch Fix build when WebAssembly is disabled
Saam Barati
Comment 3 2019-12-09 14:40:01 PST
Comment on attachment 384239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384239&action=review > Source/JavaScriptCore/ChangeLog:12 > + - We were generating 2 instances of dumpBytecode, at 30kb each > + - We had 3 instances of computeUsesForBytecodeIndex at 11kb each > + - We had 8 instances of emit_compareAndJump(Slow) at 8kb (7kb for Slow) each. you should say what you actually did. (e.g, made them one instance instead of N)
Tadeu Zagallo
Comment 4 2019-12-10 10:56:58 PST
Created attachment 385286 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-12-10 11:41:47 PST
Comment on attachment 385286 [details] Patch for landing Clearing flags on attachment: 385286 Committed r253335: <https://trac.webkit.org/changeset/253335>
WebKit Commit Bot
Comment 6 2019-12-10 11:41:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-10 11:43:22 PST
<rdar://problem/57802078>
Note You need to log in before you can comment on or make changes to this bug.