Bug 204537

Summary: [LFC][IFC] Merge "insert inline runs" and "setup display runs" loops in InlineFormattingContext::setDisplayBoxesForLine
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2019-11-22 14:12:42 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2019-11-22 14:13:24 PST 
<rdar://problem/57440394>
Comment 2 zalan 2019-11-22 14:14:59 PST 
Created attachment 384196 [details]
Patch
Comment 3 Antti Koivisto 2019-11-22 14:19:29 PST 
Comment on attachment 384196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384196&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:-432
> -    // FIXME: This is tempoary.

Omg it is permenent now.
Comment 4 zalan 2019-11-22 14:21:54 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 384196 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384196&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:-432
> > -    // FIXME: This is tempoary.
> 
> Omg it is permenent now.
A feature is being born here.
Comment 5 WebKit Commit Bot 2019-11-22 15:30:50 PST 
Comment on attachment 384196 [details]
Patch

Clearing flags on attachment: 384196

Committed r252810: <https://trac.webkit.org/changeset/252810>
Comment 6 WebKit Commit Bot 2019-11-22 15:30:52 PST 
All reviewed patches have been landed.  Closing bug.