Bug 204537 - [LFC][IFC] Merge "insert inline runs" and "setup display runs" loops in InlineFormattingContext::setDisplayBoxesForLine
Summary: [LFC][IFC] Merge "insert inline runs" and "setup display runs" loops in Inlin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-22 14:12 PST by zalan
Modified: 2019-11-22 15:30 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.08 KB, patch)
2019-11-22 14:14 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-22 14:12:42 PST
ssia
Comment 1 Radar WebKit Bug Importer 2019-11-22 14:13:24 PST
<rdar://problem/57440394>
Comment 2 zalan 2019-11-22 14:14:59 PST
Created attachment 384196 [details]
Patch
Comment 3 Antti Koivisto 2019-11-22 14:19:29 PST
Comment on attachment 384196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384196&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:-432
> -    // FIXME: This is tempoary.

Omg it is permenent now.
Comment 4 zalan 2019-11-22 14:21:54 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 384196 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384196&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:-432
> > -    // FIXME: This is tempoary.
> 
> Omg it is permenent now.
A feature is being born here.
Comment 5 WebKit Commit Bot 2019-11-22 15:30:50 PST
Comment on attachment 384196 [details]
Patch

Clearing flags on attachment: 384196

Committed r252810: <https://trac.webkit.org/changeset/252810>
Comment 6 WebKit Commit Bot 2019-11-22 15:30:52 PST
All reviewed patches have been landed.  Closing bug.