Summary: | Web Inspector: Console: the saved result value is still shown after page reload | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Devin Rousso
2019-11-22 12:58:47 PST
Created attachment 384188 [details]
Patch
Comment on attachment 384188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384188&action=review > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:248 > + for (let node of this._messageBodyElement.querySelectorAll(".console-saved-variable")) This seems fragile. Can we re-render() the messages in ConsoleMessageView and not draw the saved result index element if the message is older than the epoch (uh, probably since last page reload)? Comment on attachment 384188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384188&action=review >> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:248 >> + for (let node of this._messageBodyElement.querySelectorAll(".console-saved-variable")) > > This seems fragile. Can we re-render() the messages in ConsoleMessageView and not draw the saved result index element if the message is older than the epoch (uh, probably since last page reload)? Fragile in what way? We don't ever save the `.console-saved-variable` element to a member variable, so it's basically "dropped" into the DOM with no expectations about it afterwards. Re-rendering all of the messages would likely have pretty awful performance, especially if there are a lot of messages from previous sessions. Comment on attachment 384188 [details]
Patch
r=me
I don't think it's worth making this any more complicated at this point.
Comment on attachment 384188 [details] Patch Clearing flags on attachment: 384188 Committed r253000: <https://trac.webkit.org/changeset/253000> All reviewed patches have been landed. Closing bug. |