Bug 204521

Summary: Media queries in img sizes attribute don't evaluate dynamically
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kangil.han, kondapallykalyan, macpherson, menard, pdr, philipj, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
simon.fraser: review+
patch none

Antti Koivisto
Reported 2019-11-22 09:13:37 PST
There is no code for evaluating on viewport etc changes.
Attachments
patch (27.37 KB, patch)
2019-11-22 09:34 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (27.37 KB, patch)
2019-11-22 09:41 PST, Antti Koivisto 		simon.fraser: review+
DetailsFormatted DiffDiff
patch (27.61 KB, patch)
2019-11-23 01:36 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-11-22 09:34:42 PST
Created attachment 384160 [details] patch
Antti Koivisto
Comment 2 2019-11-22 09:41:08 PST
Created attachment 384161 [details] patch
Simon Fraser (smfr)
Comment 3 2019-11-22 12:47:28 PST
Comment on attachment 384161 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=384161&action=review > LayoutTests/fast/images/sizes-dynamic-001.html:5 > +<link rel="match" href="sizes-dynamic-001-ref.html"> Please fix this to point to the real ref file. > LayoutTests/fast/images/sizes-dynamic-002.html:5 > +<link rel="match" href="sizes-dynamic-001-ref.html"> Ditto. > Source/WebCore/dom/Document.h:1829 > + HashSet<HTMLImageElement*> m_dynamicMediaQueryDependentImages; Are we still using raw pointers for stuff like this?
Antti Koivisto
Comment 4 2019-11-22 12:58:03 PST
> Are we still using raw pointers for stuff like this? We don't have WeakPtrs for Elements yet. But maybe I could add it for HTMLImageElement.
Antti Koivisto
Comment 5 2019-11-23 00:57:08 PST
> We don't have WeakPtrs for Elements yet. But maybe I could add it for > HTMLImageElement. I'm wrong, ContainerNodes are already CanMakeWeakPtr.
Antti Koivisto
Comment 6 2019-11-23 01:36:42 PST
Created attachment 384233 [details] patch
WebKit Commit Bot
Comment 7 2019-11-23 02:19:50 PST
Comment on attachment 384233 [details] patch Clearing flags on attachment: 384233 Committed r252828: <https://trac.webkit.org/changeset/252828>
WebKit Commit Bot
Comment 8 2019-11-23 02:19:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-11-23 02:20:20 PST
<rdar://problem/57451085>
Note You need to log in before you can comment on or make changes to this bug.