Bug 204518

Summary: run-webkit-tests: Failing to run spindump shouldn't be fatal
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jonathan Bedard 2019-11-22 08:19:24 PST 
If spindump raises an exception, we sometimes abort the entire test run. This is a tremendous waste of machine time.
Comment 1 Jonathan Bedard 2019-11-22 08:19:49 PST 
<rdar://problem/57397417>
Comment 2 Jonathan Bedard 2019-11-22 08:39:15 PST 
Created attachment 384157 [details]
Patch
Comment 3 Aakash Jain 2019-11-22 08:58:56 PST 
Comment on attachment 384157 [details]
Patch

where did you notice it?
Comment 4 Jonathan Bedard 2019-11-22 09:08:39 PST 
(In reply to Aakash Jain from comment #3)
> Comment on attachment 384157 [details]
> Patch
> 
> where did you notice it?

Alexey noticed it on an Internal build. I didn't investigate too much, once I looked at the code and what the entire function does, it was transparently wrong, so I figured we should just fix it and move on.
Comment 5 WebKit Commit Bot 2019-11-22 09:51:38 PST 
Comment on attachment 384157 [details]
Patch

Clearing flags on attachment: 384157

Committed r252779: <https://trac.webkit.org/changeset/252779>
Comment 6 WebKit Commit Bot 2019-11-22 09:51:43 PST 
All reviewed patches have been landed.  Closing bug.