Bug 204518

Summary: run-webkit-tests: Failing to run spindump shouldn't be fatal
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2019-11-22 08:19:24 PST
If spindump raises an exception, we sometimes abort the entire test run. This is a tremendous waste of machine time.
Attachments
Patch (1.44 KB, patch)
2019-11-22 08:39 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-11-22 08:19:49 PST
<rdar://problem/57397417>
Jonathan Bedard
Comment 2 2019-11-22 08:39:15 PST
Created attachment 384157 [details] Patch
Aakash Jain
Comment 3 2019-11-22 08:58:56 PST
Comment on attachment 384157 [details] Patch where did you notice it?
Jonathan Bedard
Comment 4 2019-11-22 09:08:39 PST
(In reply to Aakash Jain from comment #3) > Comment on attachment 384157 [details] > Patch > > where did you notice it? Alexey noticed it on an Internal build. I didn't investigate too much, once I looked at the code and what the entire function does, it was transparently wrong, so I figured we should just fix it and move on.
WebKit Commit Bot
Comment 5 2019-11-22 09:51:38 PST
Comment on attachment 384157 [details] Patch Clearing flags on attachment: 384157 Committed r252779: <https://trac.webkit.org/changeset/252779>
WebKit Commit Bot
Comment 6 2019-11-22 09:51:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.