Bug 204501

Summary: [css-grid] Avoid serializing [] in grid-template* specified values
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: CSSAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, macpherson, menard, obrufau, webkit-bug-importer
Priority: P2 Keywords: BlinkMergeCandidate, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 204585    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2019-11-22 03:26:09 PST
Any empty list of list items can be discarded when parsing grid-template-rows, grid-template-columns, etc. This was discussed at: https://github.com/w3c/csswg-drafts/issues/4173 And this was fixed in Chromium in https://chromium-review.googlesource.com/c/chromium/src/+/1810454 This causes several failures in WPT tests under css/css-grid/parsing/
Attachments
Patch (19.71 KB, patch)
2019-11-25 13:12 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (19.71 KB, patch)
2019-11-25 13:53 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2019-11-25 13:12:18 PST
Created attachment 384313 [details] Patch
Oriol Brufau
Comment 2 2019-11-25 13:43:21 PST
Comment on attachment 384313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review > Source/WebCore/ChangeLog:15 > + Several WPT tets are passing thanks to this change. Typo: tets
Manuel Rego Casasnovas
Comment 3 2019-11-25 13:53:21 PST
Created attachment 384316 [details] Patch
Manuel Rego Casasnovas
Comment 4 2019-11-25 13:53:43 PST
Comment on attachment 384313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review >> Source/WebCore/ChangeLog:15 >> + Several WPT tets are passing thanks to this change. > > Typo: tets Oops, thanks! Fixed that one and other typos on this ChangeLog.
Manuel Rego Casasnovas
Comment 5 2019-11-25 13:53:51 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review >> Source/WebCore/ChangeLog:15 >> + Several WPT tets are passing thanks to this change. > > Typo: tets Oops, thanks! Fixed that one and other typos on this ChangeLog.
Manuel Rego Casasnovas
Comment 6 2019-11-25 23:15:10 PST
Comment on attachment 384316 [details] Patch After the patch for the tests import has landed this is ready for review. It's a small thing we haven't ported from Blink yet.
WebKit Commit Bot
Comment 7 2019-11-26 04:09:11 PST
Comment on attachment 384316 [details] Patch Clearing flags on attachment: 384316 Committed r252883: <https://trac.webkit.org/changeset/252883>
WebKit Commit Bot
Comment 8 2019-11-26 04:09:13 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-11-26 04:10:21 PST
<rdar://problem/57488378>
Note You need to log in before you can comment on or make changes to this bug.