Bug 204495

Summary: Support JSCOnly platform in test reporting
Product: WebKit Reporter: Paulo Matos <pmatos>
Component: Tools / TestsAssignee: Paulo Matos <pmatos>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Paulo Matos
Reported 2019-11-22 01:26:41 PST
Build for 32bit jsconly worker is failing since 204091 made it upstream. --report is used which causes configurationForUpload to be called but it fails without determining platform. See https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10060/steps/jscore-test/logs/stdio
Attachments
Patch (1.40 KB, patch)
2019-11-22 02:33 PST, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2019-11-22 03:40 PST, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2019-11-22 06:08 PST, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Paulo Matos
Comment 1 2019-11-22 02:33:17 PST
Created attachment 384138 [details] Patch
Paulo Matos
Comment 2 2019-11-22 03:40:05 PST
Created attachment 384140 [details] Patch
Carlos Garcia Campos
Comment 3 2019-11-22 04:59:12 PST
Comment on attachment 384140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384140&action=review > Tools/Scripts/run-javascriptcore-tests:395 > + chomp($version = `/usr/bin/uname -r`); Use just uname, that should be in PATH, see bug #204452
Paulo Matos
Comment 4 2019-11-22 06:08:57 PST
Created attachment 384146 [details] Patch
Paulo Matos
Comment 5 2019-11-22 06:09:30 PST
(In reply to Carlos Garcia Campos from comment #3) > Comment on attachment 384140 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384140&action=review > > > Tools/Scripts/run-javascriptcore-tests:395 > > + chomp($version = `/usr/bin/uname -r`); > > Use just uname, that should be in PATH, see bug #204452 Thanks for the review. Fixed in latest patch.
WebKit Commit Bot
Comment 6 2019-11-22 06:55:10 PST
Comment on attachment 384146 [details] Patch Clearing flags on attachment: 384146 Committed r252773: <https://trac.webkit.org/changeset/252773>
WebKit Commit Bot
Comment 7 2019-11-22 06:55:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-11-22 06:56:20 PST
<rdar://problem/57427984>
Note You need to log in before you can comment on or make changes to this bug.