| Summary: | replaceUsingStringSearch() should not use CachedCall with host functions. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, ross.kirsling, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2019-11-21 23:48:26 PST
Created attachment 384128 [details]
proposed patch.
Comment on attachment 384128 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=384128&action=review > Source/JavaScriptCore/runtime/StringPrototype.cpp:812 > - if (cachedCall) { > + if (callType == CallType::JS) { Might be clearer to leave this line -- then the branch reads as "if we have a cached call then call it". Comment on attachment 384128 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=384128&action=review Thanks for the review. >> Source/JavaScriptCore/runtime/StringPrototype.cpp:812 >> + if (callType == CallType::JS) { > > Might be clearer to leave this line -- then the branch reads as "if we have a cached call then call it". Good point. I'll change it. Landed in r252766: <http://trac.webkit.org/r252766>. |