| Summary: | [Cocoa] Rename some internal names for system fonts | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2019-11-21 19:19:19 PST
Created attachment 384120 [details]
Patch
Comment on attachment 384120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384120&action=review > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1272 > + Optional<SystemFontDatabaseCoreText::Purpose> systemDesign; I think SystemFontDatabaseCoreText::Purpose could have a much better name if it wasn't hobbled by the enum being inside the SystemFontDatabaseCoreText class. The fact it's a database doesn't seem relevant here. Comment on attachment 384120 [details] Patch Attachment 384120 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13272748 New failing tests: fast/workers/worker-cloneport.html Created attachment 384143 [details]
Archive of layout-test-results from ews214 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 384187 [details]
Patch
Comment on attachment 384187 [details]
Patch
So much better!
Comment on attachment 384187 [details] Patch Clearing flags on attachment: 384187 Committed r252806: <https://trac.webkit.org/changeset/252806> All reviewed patches have been landed. Closing bug. |