Bug 204464

Summary:

Remove unneeded code that annotated DOMHTMLElement as conforming to UITextInputTraits protocol

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 13

See Also:

https://bugs.webkit.org/show_bug.cgi?id=177917
https://bugs.webkit.org/show_bug.cgi?id=174394

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2019-11-21 12:03:38 PST

Following the fix for bug #177917, DOMHTMLElement no longer needs to be annotated as conforming to UITextInputTraits protocol. It never really did implement that protocol. When it was annotated as implementing the UITextInputTraits protocol it was only to register with the runtime so that callers could send -acceptsAutofilledLoginCredentials and -representingPageURL messages to it. And those functions were removed in the patch for bug bug #177917.

Attachments
Patch (2.00 KB, patch) 2019-11-21 12:13 PST, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2019-11-21 12:04:28 PST

FYI, patch for bug #174394 first annotated DOMHTMLElement as implementing the UITextInputTraits protocol

Daniel Bates

Comment 2 2019-11-21 12:13:14 PST

Created attachment 384080 [details] Patch

Daniel Bates

Comment 3 2019-11-21 12:27:52 PST

Comment on attachment 384080 [details] Patch Clearing flags on attachment: 384080 Committed r252746: <https://trac.webkit.org/changeset/252746>

Daniel Bates

Comment 4 2019-11-21 12:27:54 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-11-21 12:28:21 PST

<rdar://problem/57403788>

Note You need to log in before you can comment on or make changes to this bug.