Bug 20446

Summary: rename NPCocoaEvent's "event" struct to "data"
Product: WebKit Reporter: Josh Aas <joshmoz>
Component: Plug-insAssignee: Josh Aas <joshmoz>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: https://wiki.mozilla.org/Mac:NPAPI_Event_Models
Attachments:
Description Flags
fix v1.0 andersca: review+

Josh Aas
Reported 2008-08-19 11:21:29 PDT
We should rename NPCocoaEvent's "event" structure to "data" to avoid things like "event->event.draw.x" and "event.event.draw.x". People tend to name the NPCocoaEvent "event" and it doesn't read well. This happens often in WebKit's impl and it'll happen all over plugin code written for the Cocoa event model. We'd change the spec here: https://wiki.mozilla.org/Mac:NPAPI_Event_Models
Attachments
fix v1.0 (6.81 KB, patch)
2008-08-19 11:26 PDT, Josh Aas 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Josh Aas
Comment 1 2008-08-19 11:26:02 PDT
Created attachment 22878 [details] fix v1.0
Anders Carlsson
Comment 2 2008-08-19 11:30:18 PDT
Comment on attachment 22878 [details] fix v1.0 r=me
Anders Carlsson
Comment 3 2008-08-20 13:57:48 PDT
<rdar://problem/6163636>
Anders Carlsson
Comment 4 2008-08-20 14:04:39 PDT
Committed revision 35861.
Note You need to log in before you can comment on or make changes to this bug.