Bug 204435

Summary: GetByStatus should not say it took the slow path for multiple identifiers and should have a way to indicate if the StructureStubInfo it saw took the slow path
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
tzagallo: review+
patch for landing
none
patch for landing none

Saam Barati
Reported 2019-11-20 17:54:22 PST
I forgot to upload my microbenchmarks in the actual patch.
Attachments
patch (34.33 KB, patch)
2019-11-21 15:31 PST, Saam Barati 		tzagallo: review+
DetailsFormatted DiffDiff
patch for landing (44.49 KB, patch)
2019-11-21 17:52 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (44.51 KB, patch)
2019-11-21 17:55 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-11-21 15:31:25 PST
Created attachment 384097 [details] patch
Tadeu Zagallo
Comment 2 2019-11-21 15:44:46 PST
Comment on attachment 384097 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=384097&action=review r=me. > Source/JavaScriptCore/ChangeLog:24 > + between a GetByStatus saying "we're a slow path" and if we actually observed the StructureStubInfo > + go to the slow path. In the DFG/FTL, we only forgo emitting a get by val IC when observing a Maybe it's just me, but I found this a bit confusing throughout the patch. It's kinda weird that we say it's a slow path if the slow path wasn't taken, but I'm not sure what would be a better alternative, so I'll leave it to you to decide whether it makes sense or not.
Saam Barati
Comment 3 2019-11-21 17:52:05 PST
Created attachment 384111 [details] patch for landing
Saam Barati
Comment 4 2019-11-21 17:55:48 PST
Created attachment 384113 [details] patch for landing
WebKit Commit Bot
Comment 5 2019-11-21 21:42:04 PST
Comment on attachment 384113 [details] patch for landing Clearing flags on attachment: 384113 Committed r252763: <https://trac.webkit.org/changeset/252763>
WebKit Commit Bot
Comment 6 2019-11-21 21:42:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-21 21:43:21 PST
<rdar://problem/57419422>
Note You need to log in before you can comment on or make changes to this bug.