Bug 204434

Summary: Crash at com.apple.WebCore: -[WebRevealHighlight revealContext:drawRectsForItem:]
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: PDFAssignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, conrad_shultz, ews-watchlist, megan_gardner, mifenton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Conrad Shultz 2019-11-20 17:50:48 PST 
It's possible to trigger a crash under -[WebRevealHighlight revealContext:drawRectsForItem:].
Comment 1 Conrad Shultz 2019-11-20 17:51:55 PST 
<rdar://problem/57123416>
Comment 2 Conrad Shultz 2019-11-20 17:56:12 PST 
Created attachment 384016 [details]
Patch
Comment 3 Megan Gardner 2019-11-20 18:09:13 PST 
Comment on attachment 384016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384016&action=review

r+ as long as you make sure that old systems aren't going to be broken.

> Source/WebCore/editing/cocoa/DictionaryLookup.mm:82
>  }

I know I did this on purpose, I believe so that it would work on older 32 bit systems, but we might not compile for them anymore. Please verify that this is true before removing.

> Source/WebCore/editing/cocoa/DictionaryLookup.mm:-101
> -

Ditto.
Comment 4 Conrad Shultz 2019-11-20 22:33:03 PST 
(In reply to Megan Gardner from comment #3)
> Comment on attachment 384016 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384016&action=review
> 
> r+ as long as you make sure that old systems aren't going to be broken.
> 
> > Source/WebCore/editing/cocoa/DictionaryLookup.mm:82
> >  }
> 
> I know I did this on purpose, I believe so that it would work on older 32
> bit systems, but we might not compile for them anymore. Please verify that
> this is true before removing.
> 
> > Source/WebCore/editing/cocoa/DictionaryLookup.mm:-101
> > -
> 
> Ditto.

We should be good as of macOS Catalina. Bots are green too. Thanks!
Comment 5 WebKit Commit Bot 2019-11-20 23:25:50 PST 
Comment on attachment 384016 [details]
Patch

Clearing flags on attachment: 384016

Committed r252729: <https://trac.webkit.org/changeset/252729>
Comment 6 WebKit Commit Bot 2019-11-20 23:25:51 PST 
All reviewed patches have been landed.  Closing bug.