Bug 204432

Summary: Baseline JIT should fill in StructureStubInfo's propertyIsInt32 and the slow path should update the array profile more frequently
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch tzagallo: review+

Saam Barati
Reported 2019-11-20 17:37:31 PST
...
Attachments
patch (3.59 KB, patch)
2019-11-20 17:47 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (3.59 KB, patch)
2019-11-20 17:49 PST, Saam Barati 		tzagallo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-11-20 17:47:50 PST
Created attachment 384013 [details] patch
Saam Barati
Comment 2 2019-11-20 17:48:42 PST
Comment on attachment 384013 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=384013&action=review > Source/JavaScriptCore/jit/JITOperations.cpp:2013 > + Structure* structure = baseValue.structureOrNull(); let me improve this to just call structure()
Saam Barati
Comment 3 2019-11-20 17:49:57 PST
Created attachment 384014 [details] patch
Tadeu Zagallo
Comment 4 2019-11-20 17:51:54 PST
Comment on attachment 384014 [details] patch r=me
Saam Barati
Comment 5 2019-11-20 18:00:38 PST
landed in: https://trac.webkit.org/changeset/252725/webkit
Radar WebKit Bug Importer
Comment 6 2019-11-20 18:01:24 PST
<rdar://problem/57380299>
Note You need to log in before you can comment on or make changes to this bug.