Web Inspector: call frames from blackboxed scripts should be visually distinct

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

Seeing "Deferred pause from blackboxed script" in the Pause Reason does clarify that something in the Call Stack was blackboxed, but it doesn't indicate what was blackboxed.  Given that the debugger effectively ignores blackboxed scripts, we should distinguish them as such in the UI.

[Devin Rousso]

Created attachment 383992 [details]
Patch

[Devin Rousso]

Created attachment 383993 [details]
[Image] After Patch is applied

[Timothy Hatcher]

Comment on attachment 383992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383992&action=review

> Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js:96
> +                tooltipSuffix += "\n\n" + WI.UIString("Script ignored when debugging");

This should mention black boxing as a reason why it was ignored.

[Devin Rousso]

Created attachment 384076 [details]
Patch

[Devin Rousso]

Comment on attachment 384076 [details]
Patch

I also updated the tooltip/contextmenu text for things related to blackboxing so they actually include the word "blackbox" (or something like it).

[WebKit Commit Bot]

Comment on attachment 384076 [details]
Patch

Clearing flags on attachment: 384076

Committed r252745: <https://trac.webkit.org/changeset/252745>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57403149>