Bug 204424

Summary: Web Inspector: call frames from blackboxed scripts should be visually distinct
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied
none
Patch none

Devin Rousso
Reported 2019-11-20 15:09:46 PST
Seeing "Deferred pause from blackboxed script" in the Pause Reason does clarify that something in the Call Stack was blackboxed, but it doesn't indicate what was blackboxed. Given that the debugger effectively ignores blackboxed scripts, we should distinguish them as such in the UI.
Attachments
Patch (6.22 KB, patch)
2019-11-20 15:25 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (205.11 KB, image/png)
2019-11-20 15:25 PST, Devin Rousso 		no flags
Details
Patch (10.88 KB, patch)
2019-11-21 11:19 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-11-20 15:25:19 PST
Created attachment 383992 [details] Patch
Devin Rousso
Comment 2 2019-11-20 15:25:31 PST
Created attachment 383993 [details] [Image] After Patch is applied
Timothy Hatcher
Comment 3 2019-11-21 03:30:41 PST
Comment on attachment 383992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383992&action=review > Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js:96 > + tooltipSuffix += "\n\n" + WI.UIString("Script ignored when debugging"); This should mention black boxing as a reason why it was ignored.
Devin Rousso
Comment 4 2019-11-21 11:19:46 PST
Created attachment 384076 [details] Patch
Devin Rousso
Comment 5 2019-11-21 11:20:19 PST
Comment on attachment 384076 [details] Patch I also updated the tooltip/contextmenu text for things related to blackboxing so they actually include the word "blackbox" (or something like it).
WebKit Commit Bot
Comment 6 2019-11-21 12:06:27 PST
Comment on attachment 384076 [details] Patch Clearing flags on attachment: 384076 Committed r252745: <https://trac.webkit.org/changeset/252745>
WebKit Commit Bot
Comment 7 2019-11-21 12:06:29 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-11-21 12:07:24 PST
<rdar://problem/57403149>
Note You need to log in before you can comment on or make changes to this bug.