Bug 204422

Summary:

Experimental support for HDR media query

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, benjamin, cdumez, cmarcelo, commit-queue, dbates, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, philipj, ryuan.choi, sergio

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews210 for win-future	none
Patch for landing	none
Patch for landing	none
Follow-up fix	none

Jer Noble

Reported 2019-11-20 14:59:25 PST

Experimental support for HDR media query

Attachments
Patch (32.67 KB, patch) 2019-11-20 15:03 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (31.93 KB, patch) 2019-11-20 15:04 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (32.05 KB, patch) 2019-11-20 17:57 PST, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews210 for win-future (13.81 MB, application/zip) 2019-11-20 20:00 PST, EWS Watchlist	no flags	Details
Patch for landing (37.05 KB, patch) 2019-11-21 14:30 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (37.29 KB, patch) 2019-11-21 16:28 PST, Jer Noble	no flags	Details Formatted Diff Diff
Follow-up fix (2.85 KB, patch) 2019-12-03 10:52 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2019-11-20 15:03:38 PST

Created attachment 383987 [details] Patch

Jer Noble

Comment 2 2019-11-20 15:04:36 PST

Created attachment 383988 [details] Patch

Jer Noble

Comment 3 2019-11-20 17:57:29 PST

Created attachment 384017 [details] Patch

EWS Watchlist

Comment 4 2019-11-20 20:00:34 PST Comment hidden (obsolete)

Comment on attachment 384017 [details] Patch Attachment 384017 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13270400 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 5 2019-11-20 20:00:36 PST Comment hidden (obsolete)

Created attachment 384022 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Jer Noble

Comment 6 2019-11-21 09:54:24 PST

Windows EWS failure seems unrelated.

Eric Carlson

Comment 7 2019-11-21 10:32:50 PST

Comment on attachment 384017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384017&action=review > Source/WebCore/css/MediaQueryExpression.cpp:61 > + || mediaFeature == MediaFeatureNames::dynamicRange; Shouldn't this consider hdrMediaCapabilitiesEnabled? > Source/WebCore/platform/cocoa/MediaToolboxSoftLink.cpp:35 > +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, MediaToolbox) > + > +SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE(WebCore, MediaToolbox, MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList)) Is there any reason to not put this in PAL?

Jer Noble

Comment 8 2019-11-21 13:27:02 PST

Comment on attachment 384017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384017&action=review >> Source/WebCore/css/MediaQueryExpression.cpp:61 >> + || mediaFeature == MediaFeatureNames::dynamicRange; > > Shouldn't this consider hdrMediaCapabilitiesEnabled? No, that's taken care of when the value is parsed later. >> Source/WebCore/platform/cocoa/MediaToolboxSoftLink.cpp:35 >> +SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE(WebCore, MediaToolbox, MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList)) > > Is there any reason to not put this in PAL? Sure, we can move this into PAL.

Jer Noble

Comment 9 2019-11-21 14:30:16 PST

Created attachment 384091 [details] Patch for landing

Jer Noble

Comment 10 2019-11-21 16:28:45 PST

Created attachment 384101 [details] Patch for landing

Jer Noble

Comment 11 2019-11-21 20:30:33 PST

<rdar://problem/56799662>

WebKit Commit Bot

Comment 12 2019-11-21 21:17:09 PST

Comment on attachment 384101 [details] Patch for landing Clearing flags on attachment: 384101 Committed r252762: <https://trac.webkit.org/changeset/252762>

WebKit Commit Bot

Comment 13 2019-11-21 21:17:11 PST

All reviewed patches have been landed. Closing bug.

Jer Noble

Comment 14 2019-12-03 10:52:26 PST

Reopening to attach new patch.

Jer Noble

Comment 15 2019-12-03 10:52:27 PST

Created attachment 384725 [details] Follow-up fix

WebKit Commit Bot

Comment 16 2019-12-03 14:35:49 PST

Comment on attachment 384725 [details] Follow-up fix Clearing flags on attachment: 384725 Committed r253062: <https://trac.webkit.org/changeset/253062>

WebKit Commit Bot

Comment 17 2019-12-03 14:35:51 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.