Summary: | [LFC][IFC] Cache InlinteTextItem width when possible | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2019-11-20 07:43:41 PST
Created attachment 383965 [details]
Patch
Comment on attachment 383965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383965&action=review > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:93 > + auto inlineItemWidth = [&] (auto startPosition, auto length) -> Optional<LayoutUnit> { "[](#spacing-lambda-paren) Do not place spaces between square brackets and parentheses of a lambda function but do place a space before braces." You r+'d it! (In reply to Antti Koivisto from comment #3) > Comment on attachment 383965 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383965&action=review > > > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:93 > > + auto inlineItemWidth = [&] (auto startPosition, auto length) -> Optional<LayoutUnit> { > > "[](#spacing-lambda-paren) Do not place spaces between square brackets and > parentheses of a lambda function but do place a space before braces." > > You r+'d it! must have been one of those 3am reviews. Created attachment 383970 [details]
Patch
Comment on attachment 383970 [details] Patch Clearing flags on attachment: 383970 Committed r252696: <https://trac.webkit.org/changeset/252696> All reviewed patches have been landed. Closing bug. |