Bug 204412

Summary: [LFC][IFC] Cache InlinteTextItem width when possible
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2019-11-20 07:43:41 PST
so that subsequent inline layouts don't need to keep remeasuring the text width (I know width-cache helps a bit but still).
Comment 1 Radar WebKit Bug Importer 2019-11-20 07:44:33 PST
<rdar://problem/57359366>
Comment 2 zalan 2019-11-20 07:49:27 PST
Created attachment 383965 [details]
Patch
Comment 3 Antti Koivisto 2019-11-20 09:50:43 PST
Comment on attachment 383965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383965&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:93
> +    auto inlineItemWidth = [&] (auto startPosition, auto length) -> Optional<LayoutUnit> {

"[](#spacing-lambda-paren) Do not place spaces between square brackets and parentheses of a lambda function but do place a space before braces."

You r+'d it!
Comment 4 zalan 2019-11-20 09:55:10 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 383965 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383965&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:93
> > +    auto inlineItemWidth = [&] (auto startPosition, auto length) -> Optional<LayoutUnit> {
> 
> "[](#spacing-lambda-paren) Do not place spaces between square brackets and
> parentheses of a lambda function but do place a space before braces."
> 
> You r+'d it!
must have been one of those 3am reviews.
Comment 5 zalan 2019-11-20 10:13:58 PST
Created attachment 383970 [details]
Patch
Comment 6 WebKit Commit Bot 2019-11-20 10:57:06 PST
Comment on attachment 383970 [details]
Patch

Clearing flags on attachment: 383970

Committed r252696: <https://trac.webkit.org/changeset/252696>
Comment 7 WebKit Commit Bot 2019-11-20 10:57:08 PST
All reviewed patches have been landed.  Closing bug.