Bug 204376

Summary: Assertion failure in HTMLMediaElement::enterFullscreen()
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 13   
Hardware: iPhone / iPad   
OS: iOS 13   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch
none
Patch none

Description Peng Liu 2019-11-19 14:15:40 PST
Calling function video.webkitSetPresentationMode('inline') when the video element is in inline mode will fail at "ASSERT(mode != VideoFullscreenModeNone)" in HTMLMediaElement::enterFullscreen().
Comment 1 Radar WebKit Bug Importer 2019-11-19 14:16:20 PST
<rdar://problem/57336207>
Comment 2 Peng Liu 2019-11-19 15:55:38 PST
The failure only happens on iPads.
Comment 3 Peng Liu 2019-11-19 16:06:54 PST
Created attachment 383918 [details]
Patch
Comment 4 Eric Carlson 2019-11-19 16:24:42 PST
Comment on attachment 383918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383918&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests are required.

This should say why no new tests are required.
Comment 5 Peng Liu 2019-11-19 16:57:02 PST
Created attachment 383924 [details]
Patch
Comment 6 Peng Liu 2019-11-19 17:05:54 PST
Created attachment 383927 [details]
Patch
Comment 7 WebKit Commit Bot 2019-11-19 18:37:23 PST
Comment on attachment 383927 [details]
Patch

Clearing flags on attachment: 383927

Committed r252675: <https://trac.webkit.org/changeset/252675>