Bug 204374

Summary:

Bring up WebGL Test Queue

Product:

WebKit

Reporter:

Matt Lewis <jlewis3>

Component:

Tools / Tests

Assignee:

Matt Lewis <jlewis3>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-watchlist, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=204327

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews210 for win-future	none
Patch	jbedard: review+

Matt Lewis

Reported 2019-11-19 14:00:57 PST

Making config changes to bring up WebGL testing queue.

Attachments
Patch (2.98 KB, patch) 2019-11-19 14:08 PST, Matt Lewis	no flags	Details Formatted Diff Diff
Patch (5.91 KB, patch) 2019-11-19 16:45 PST, Matt Lewis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews210 for win-future (14.28 MB, application/zip) 2019-11-19 23:07 PST, EWS Watchlist	no flags	Details
Patch (5.90 KB, patch) 2019-11-20 09:58 PST, Matt Lewis	jbedard: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-11-19 14:01:49 PST

<rdar://problem/57335349>

Matt Lewis

Comment 2 2019-11-19 14:08:25 PST

Created attachment 383903 [details] Patch

Aakash Jain

Comment 3 2019-11-19 14:11:01 PST

Comment on attachment 383903 [details] Patch Please update unit-tests, and also verify that 'buildbot checkconfig' passes.

Matt Lewis

Comment 4 2019-11-19 16:45:06 PST

Created attachment 383920 [details] Patch

Alexey Proskuryakov

Comment 5 2019-11-19 20:06:53 PST

Comment on attachment 383920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383920&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:120 > + "additionalArguments": ["--no-retry-failures", "--webgl"], Not a fan of the —webgl switch name. It’s not clear at all from looking at this what it does.

EWS Watchlist

Comment 6 2019-11-19 23:07:17 PST

Comment on attachment 383920 [details] Patch Attachment 383920 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13268580 New failing tests: fast/dom/domTokenListIterator.html fast/dom/nodeListIterator.html fast/dom/NodeList/nodelist-iterable.html http/tests/security/cross-frame-access-enumeration.html

EWS Watchlist

Comment 7 2019-11-19 23:07:19 PST

Created attachment 383947 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Jonathan Bedard

Comment 8 2019-11-20 09:15:41 PST

(In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 383920 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383920&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:120 > > + "additionalArguments": ["--no-retry-failures", "--webgl"], > > Not a fan of the —webgl switch name. It’s not clear at all from looking at > this what it does. The help message for --webgl make it clear what the option does, as does the output of run-webkit-tests when you invoke with that argument. Although, perhaps more importantly, that code hasn't landed yet <https://bugs.webkit.org/show_bug.cgi?id=204327>. Do you have a better idea for what this argument should be?

Matt Lewis

Comment 9 2019-11-20 09:58:36 PST

Created attachment 383968 [details] Patch

Jonathan Bedard

Comment 10 2019-11-20 11:35:23 PST

Comment on attachment 383968 [details] Patch Landing this before https://bugs.webkit.org/show_bug.cgi?id=204327 feels wrong though, even if it won't take effect until a restart.

Matt Lewis

Comment 11 2019-11-20 13:04:10 PST

Committed r252703: <https://trac.webkit.org/changeset/252703>

Note You need to log in before you can comment on or make changes to this bug.