Bug 204364 – results.webkit.org: Have build.webkit.org report JSC tests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

Buildbot should report JSC results data.

[Jonathan Bedard]

Created attachment 383886 [details]
Patch

[Aakash Jain]

Comment on attachment 383886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:347
> +        "--json-output={0}".format(jsonFileName), WithProperties("--%(configuration)s"),

let's keep WithProperties in separate line as it's not related to 'json-output'.

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:351
> +        "--master-name", "webkit.org",

what does master-name indicate and why is it webkit.org?

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:352
> +        "--buildbot-master", "build.webkit.org",

build.webkit.org should be a common variable (preferably declared at the beginning of this file). 

Further better, if this could be interpreted from the hostname (socket.gethostname().strip()), e.g.: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/master.cfg#L75

This would ensure that a uat/testing instance do not impersonate build.webkit.org by mistake.

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:353
> +        "--report", RESULTS_WEBKIT,

although it's not part of this patch, I think RESULTS_WEBKIT should be renamed to RESULTS_WEBKIT_URL

[Aakash Jain]

Comment on attachment 383886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review

> Tools/ChangeLog:3
> +        results.webkit.org: Have buildbot report JSC tests

We have multiple buildbot instance. Updated bug title to say build.webkit.org

[Jonathan Bedard]

Comment on attachment 383886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:351
>> +        "--master-name", "webkit.org",
> 
> what does master-name indicate and why is it webkit.org?

That's a key from run-webkit-tests that involved reporting to the old results database. Shouldn't have been included.

[Jonathan Bedard]

Created attachment 383897 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 383897 [details]
Patch

Clearing flags on attachment: 383897

Committed r252648: <https://trac.webkit.org/changeset/252648>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57335653>