Summary: | results.webkit.org: Have build.webkit.org report JSC tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, jbedard, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=204091 https://bugs.webkit.org/show_bug.cgi?id=204513 |
||||||||
Attachments: |
|
Description
Jonathan Bedard
2019-11-19 11:11:56 PST
Created attachment 383886 [details]
Patch
Comment on attachment 383886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:347 > + "--json-output={0}".format(jsonFileName), WithProperties("--%(configuration)s"), let's keep WithProperties in separate line as it's not related to 'json-output'. > Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:351 > + "--master-name", "webkit.org", what does master-name indicate and why is it webkit.org? > Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:352 > + "--buildbot-master", "build.webkit.org", build.webkit.org should be a common variable (preferably declared at the beginning of this file). Further better, if this could be interpreted from the hostname (socket.gethostname().strip()), e.g.: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/master.cfg#L75 This would ensure that a uat/testing instance do not impersonate build.webkit.org by mistake. > Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:353 > + "--report", RESULTS_WEBKIT, although it's not part of this patch, I think RESULTS_WEBKIT should be renamed to RESULTS_WEBKIT_URL Comment on attachment 383886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review > Tools/ChangeLog:3 > + results.webkit.org: Have buildbot report JSC tests We have multiple buildbot instance. Updated bug title to say build.webkit.org Comment on attachment 383886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:351 >> + "--master-name", "webkit.org", > > what does master-name indicate and why is it webkit.org? That's a key from run-webkit-tests that involved reporting to the old results database. Shouldn't have been included. Created attachment 383897 [details]
Patch
Comment on attachment 383897 [details] Patch Clearing flags on attachment: 383897 Committed r252648: <https://trac.webkit.org/changeset/252648> All reviewed patches have been landed. Closing bug. |