Bug 204358

Summary: [iOS] Fix sysctl-read sandbox violation
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch none

Per Arne Vollan
Reported Tuesday, November 19, 2019 6:33:24 PM UTC
The WebContent sandbox should allow sysctl-read of "kern.hostname".
Attachments
Patch (1.24 KB, patch)
2019-11-19 10:35 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2019-11-19 12:08 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 Tuesday, November 19, 2019 6:33:44 PM UTC
rdar://problem/57298313
Per Arne Vollan
Comment 2 Tuesday, November 19, 2019 6:35:06 PM UTC
Created attachment 383880 [details] Patch
Brent Fulgham
Comment 3 Tuesday, November 19, 2019 7:28:44 PM UTC
Comment on attachment 383880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383880&action=review r=me > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:852 > + "kern.hostname" I propose we also add the other two items we noticed in this same patch? kern.osrelease kern.version
Per Arne Vollan
Comment 4 Tuesday, November 19, 2019 7:37:33 PM UTC
(In reply to Brent Fulgham from comment #3) > Comment on attachment 383880 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383880&action=review > > r=me > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:852 > > + "kern.hostname" > > I propose we also add the other two items we noticed in this same patch? > > kern.osrelease > kern.version Will do! Thanks for reviewing :)
Per Arne Vollan
Comment 5 Tuesday, November 19, 2019 8:08:33 PM UTC
Created attachment 383893 [details] Patch
Brent Fulgham
Comment 6 Tuesday, November 19, 2019 8:12:33 PM UTC
Comment on attachment 383893 [details] Patch Looks great! r=me
WebKit Commit Bot
Comment 7 Tuesday, November 19, 2019 9:00:28 PM UTC
Comment on attachment 383893 [details] Patch Clearing flags on attachment: 383893 Committed r252643: <https://trac.webkit.org/changeset/252643>
Aakash Jain
Comment 8 Wednesday, November 20, 2019 1:20:02 AM UTC
> Committed r252643: <https://trac.webkit.org/changeset/252643> Did you want to close the bug as well?
Per Arne Vollan
Comment 9 Wednesday, November 20, 2019 7:37:54 PM UTC
(In reply to Aakash Jain from comment #8) > > Committed r252643: <https://trac.webkit.org/changeset/252643> > Did you want to close the bug as well? Yes, thanks!
Brent Fulgham
Comment 10 Monday, January 13, 2020 8:53:18 PM UTC
*** Bug 204359 has been marked as a duplicate of this bug. ***
Brent Fulgham
Comment 11 Monday, January 13, 2020 8:54:14 PM UTC
*** Bug 204360 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.