Bug 204354 – [LFC][IFC] Assign inlineCapacity to various inline run vectors.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/57322347>

[alan]

Created attachment 383869 [details]
Patch

[alan]

Created attachment 383874 [details]
Patch

[Antti Koivisto]

Comment on attachment 383874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383874&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingState.h:43
> +using InlineItems = Vector<std::unique_ptr<InlineItem>, 30>;
> +using InlineRuns = Vector<std::unique_ptr<Display::Run>, 10>;
> +using LineBoxes = Vector<std::unique_ptr<LineBox>, 5>;

Maybe some of these can be Vector<Foo,..> instead of Vector<std::unique_ptr<Foo>,...> too? Would probably be faster if we can avoid heap allocations.

> Source/WebCore/layout/inlineformatting/InlineLine.h:72
> +        Run& operator=(Run&& other);

I don't see implementation of this. I suppose it is not needed if things compile/link.

If you need it, you can default it too.

[Antti Koivisto]

Also for any temporary vectors, it likely won't hurt to have more inline capacity than usually needed. No need to tune them to common case.

[alan]

Created attachment 383879 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 383879 [details]
Patch

Clearing flags on attachment: 383879

Committed r252638: <https://trac.webkit.org/changeset/252638>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.