Bug 204327

Summary: [WebGL] Add `--webgl-test-suite` flag for run-webkit-tests
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: WebGLAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dean_johnson, dino, ews-watchlist, glenn, jbedard, jlewis3, justin_fan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204374
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Justin Fan
Reported 2019-11-18 15:43:03 PST
`run-webkit-tests --webgl` is an alias for `run-webkit-tests webgl --additional-expectations=LayoutTests/webgl/TestExpectations`, from the OpenSource directory. "LayoutTests/webgl/TestExpectations" has one line, initially: `webgl [ Pass Slow ]`
Attachments
Patch (3.01 KB, patch)
2019-11-18 17:16 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.79 KB, patch)
2019-11-19 14:48 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.82 KB, patch)
2019-11-20 09:37 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.85 KB, patch)
2019-11-20 12:18 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.86 KB, patch)
2019-11-20 13:30 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-11-18 17:16:34 PST
Created attachment 383811 [details] Patch
Justin Fan
Comment 2 2019-11-19 10:30:31 PST
Thanks! RS=me
Aakash Jain
Comment 3 2019-11-19 12:03:56 PST
Comment on attachment 383811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383811&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:358 > + if args[0].webgl: would webgl always be first argument?
Jonathan Bedard
Comment 4 2019-11-19 12:08:46 PST
Comment on attachment 383811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383811&action=review >> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:358 >> + if args[0].webgl: > > would webgl always be first argument? Yes. This is using the old Python argument parser, 'args' is actually a tuple. Maybe I should re-write this as: options, args = option_parser.parse_args(args) This first bit is an object constructed by the argparser that will have all of our options in it, the second bit is directories to be run
Aakash Jain
Comment 5 2019-11-19 14:13:38 PST
Dean Johnson, can you have a look please?
Jonathan Bedard
Comment 6 2019-11-19 14:48:54 PST
Created attachment 383908 [details] Patch
Jonathan Bedard
Comment 7 2019-11-20 09:37:43 PST
Created attachment 383967 [details] Patch
Aakash Jain
Comment 8 2019-11-20 12:02:00 PST
Comment on attachment 383967 [details] Patch rs=me
Jonathan Bedard
Comment 9 2019-11-20 12:18:13 PST
Created attachment 383978 [details] Patch for landing
WebKit Commit Bot
Comment 10 2019-11-20 13:24:25 PST
Comment on attachment 383978 [details] Patch for landing Rejecting attachment 383978 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 383978, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13269797
Jonathan Bedard
Comment 11 2019-11-20 13:30:31 PST
Created attachment 383981 [details] Patch for landing
WebKit Commit Bot
Comment 12 2019-11-20 14:45:32 PST
Comment on attachment 383981 [details] Patch for landing Clearing flags on attachment: 383981 Committed r252711: <https://trac.webkit.org/changeset/252711>
WebKit Commit Bot
Comment 13 2019-11-20 14:45:34 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2019-11-20 14:46:44 PST
<rdar://problem/57373703>
Note You need to log in before you can comment on or make changes to this bug.