Bug 204326

Summary:

Fix load<16> on ARM64

Product:

WebKit

Reporter:

Robin Morisset <rmorisset>

Component:

JavaScriptCore

Assignee:

Robin Morisset <rmorisset>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=202832

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Robin Morisset

Reported 2019-11-18 15:24:45 PST

It was introduced in https://bugs.webkit.org/show_bug.cgi?id=202832, and Daniel Bates notified me of a bug in it. More precisely, it calls ldr<16>, which calls CHECK_DATASIZE which in turns does an ASSERT(16 == 32 || 16 == 64); I am still trying to see if I can just remove the assert (which looks plain wrong), or if there is a more serious problem here. <rdar://problem/57297184> REGRESSION (r252422) CHECK_DATASIZE() fails loading docs.google.com

Attachments
Patch (1.73 KB, patch) 2019-11-18 16:13 PST, Robin Morisset	no flags	Details Formatted Diff Diff
Patch (1.79 KB, patch) 2019-11-18 16:21 PST, Robin Morisset	no flags	Details Formatted Diff Diff
Patch (1.77 KB, patch) 2019-11-18 16:29 PST, Robin Morisset	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.