Summary: | Check if ITP is on before applying third-party cookie blocking | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||
Component: | WebKit Misc. | Assignee: | John Wilander <wilander> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=204109 | ||||||||
Attachments: |
|
Description
John Wilander
2019-11-18 15:02:32 PST
Created attachment 383795 [details]
Patch
Comment on attachment 383795 [details]
Patch
Checking EWS before landing.
Looking into test failure. Found the issue. Trunk uses a different WebsiteDataStore for the TestRunner and I must turn ITP on/off on that store. New patch coming up. Created attachment 383834 [details]
Patch
Comment on attachment 383834 [details]
Patch
Again checking EWS before landing. The only change is for TestController::setStatisticsEnabled() to use TestController::websiteDataStore() in the call to WKWebsiteDataStoreSetResourceLoadStatisticsEnabled().
Comment on attachment 383834 [details] Patch Clearing flags on attachment: 383834 Committed r252623: <https://trac.webkit.org/changeset/252623> All reviewed patches have been landed. Closing bug. |