Bug 204322

Summary: Check if ITP is on before applying third-party cookie blocking
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204109
Attachments:
Description Flags
Patch
none
Patch none

Description John Wilander 2019-11-18 15:02:32 PST 
<rdar://problem/57120772>
Comment 1 John Wilander 2019-11-18 15:05:19 PST 
Created attachment 383795 [details]
Patch
Comment 2 John Wilander 2019-11-18 15:05:38 PST 
Comment on attachment 383795 [details]
Patch

Checking EWS before landing.
Comment 3 John Wilander 2019-11-18 16:06:18 PST 
Looking into test failure.
Comment 4 John Wilander 2019-11-18 19:39:24 PST 
Found the issue. Trunk uses a different WebsiteDataStore for the TestRunner and I must turn ITP on/off on that store. New patch coming up.
Comment 5 John Wilander 2019-11-18 19:47:06 PST 
Created attachment 383834 [details]
Patch
Comment 6 John Wilander 2019-11-18 19:49:16 PST 
Comment on attachment 383834 [details]
Patch

Again checking EWS before landing. The only change is for TestController::setStatisticsEnabled() to use TestController::websiteDataStore() in the call to WKWebsiteDataStoreSetResourceLoadStatisticsEnabled().
Comment 7 WebKit Commit Bot 2019-11-18 22:30:54 PST 
Comment on attachment 383834 [details]
Patch

Clearing flags on attachment: 383834

Committed r252623: <https://trac.webkit.org/changeset/252623>
Comment 8 WebKit Commit Bot 2019-11-18 22:30:56 PST 
All reviewed patches have been landed.  Closing bug.