| Summary: | Clarify that OptionRange::operator=() is only used for initializing to 0 (i.e. state Uninitialized). | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2019-11-18 12:15:29 PST
Created attachment 383776 [details]
proposed patch.
Comment on attachment 383776 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=383776&action=review > Source/JavaScriptCore/ChangeLog:3 > + Clarify that OptionRange::operator=() is only used for initialized to 0 (i.e. state Uninitialized). Will replace /initialized/initializing/. Comment on attachment 383776 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=383776&action=review > Source/JavaScriptCore/runtime/OptionsList.h:554 > + OptionRange& operator= (int value) no space Thanks for the review. (In reply to Saam Barati from comment #3) > > Source/JavaScriptCore/runtime/OptionsList.h:554 > > + OptionRange& operator= (int value) > > no space Fixed. Landed in r252558: <http://trac.webkit.org/r252558>. |