Bug 204303

Summary: Delete unused visually non-empty methods from FrameView
Product: WebKit Reporter: Ben Nham <nham>
Component: Layout and RenderingAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ben Nham
Reported 2019-11-18 10:28:38 PST
FrameView has some methods in its header (updateIsVisuallyNonEmpty and updateSignificantRenderedTextMilestoneIfNeeded) that used to be part of the visually non-empty logic, but are no longer implemented. Delete them.
Attachments
Patch (1.42 KB, patch)
2019-11-18 10:30 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Nham
Comment 1 2019-11-18 10:30:42 PST
Created attachment 383760 [details] Patch
WebKit Commit Bot
Comment 2 2019-11-18 11:09:41 PST
Comment on attachment 383760 [details] Patch Clearing flags on attachment: 383760 Committed r252552: <https://trac.webkit.org/changeset/252552>
WebKit Commit Bot
Comment 3 2019-11-18 11:09:43 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-11-18 11:10:22 PST
<rdar://problem/57290015>
Note You need to log in before you can comment on or make changes to this bug.