Bug 204287

Summary: [Clipboard API] Add support for Clipboard.writeText()
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, darin, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix GTK/WPE builds none

Description Wenson Hsieh 2019-11-17 19:40:12 PST 
Implement Clipboard.writeText().
Comment 1 Radar WebKit Bug Importer 2019-11-17 19:40:30 PST 
<rdar://problem/57270440>
Comment 2 Wenson Hsieh 2019-11-17 20:13:11 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2019-11-17 20:15:58 PST 
Created attachment 383725 [details]
Fix GTK/WPE builds
Comment 4 WebKit Commit Bot 2019-11-18 13:22:38 PST 
Comment on attachment 383725 [details]
Fix GTK/WPE builds

Clearing flags on attachment: 383725

Committed r252561: <https://trac.webkit.org/changeset/252561>
Comment 5 WebKit Commit Bot 2019-11-18 13:22:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2019-11-20 15:52:49 PST 
Comment on attachment 383725 [details]
Fix GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=383725&action=review

> Source/WebCore/Modules/async-clipboard/Clipboard.cpp:107
> +    if (!document || !frame || !shouldProceedWithClipboardWrite(*frame)) {

No need for the "!frame" check here.
Comment 7 Wenson Hsieh 2019-11-20 16:29:38 PST 
Comment on attachment 383725 [details]
Fix GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=383725&action=review

>> Source/WebCore/Modules/async-clipboard/Clipboard.cpp:107
>> +    if (!document || !frame || !shouldProceedWithClipboardWrite(*frame)) {
> 
> No need for the "!frame" check here.

Good catch — non-null document already implies non-null frame here. Fixed in r252718.