| Summary: | Python 3: Support run-api-tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, commit-queue, dean_johnson, ews-watchlist, glenn, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=184986 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2019-11-15 15:02:14 PST
Created attachment 383789 [details]
Patch
Comment on attachment 383789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383789&action=review Looks good to me; unofficial r+. > Tools/Scripts/webkitpy/api_tests/manager.py:185 > + test_names = [test for test in test_names for _ in range(self._options.repeat_each)] Long-standing bug here that this can blow up with a pretty high repeat_each count. Since test_names is stored as a list though, it shouldn't be any different than it was before. rs=me Comment on attachment 383789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383789&action=review >> Tools/Scripts/webkitpy/api_tests/manager.py:185 >> + test_names = [test for test in test_names for _ in range(self._options.repeat_each)] > > Long-standing bug here that this can blow up with a pretty high repeat_each count. Since test_names is stored as a list though, it shouldn't be any different than it was before. True, but if it does blow up, we wouldn't be able to store the results from the run in RAM anyways, so not sure how useful they would be. Created attachment 383814 [details]
Patch for landing
Comment on attachment 383814 [details] Patch for landing Clearing flags on attachment: 383814 Committed r252616: <https://trac.webkit.org/changeset/252616> All reviewed patches have been landed. Closing bug. |