Summary: | REGRESSION (r195080): prepare-ChangeLog does not emit function list for file paths that contain a space | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, ews-watchlist, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 137982 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Daniel Bates
2019-11-15 11:17:19 PST
Why did bug #137982 break things? I explained in bug 137982, comment 6. Created attachment 383631 [details]
Patch
Comment on attachment 383631 [details] Patch Attachment 383631 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13259035 New failing tests: animations/no-style-recalc-during-accelerated-animation.html Created attachment 383655 [details]
Archive of layout-test-results from ews214 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
(In reply to Build Bot from comment #4) > Created attachment 383655 [details] > Archive of layout-test-results from ews214 for win-future > > The attached test failures were seen while running run-webkit-tests on the > win-ews. > Bot: ews214 Port: win-future Platform: > CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit ^^^ Ignore. Patch doesn't affect tests. Comment on attachment 383631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383631&action=review > Tools/ChangeLog:11 > + the unescape file path. Subsequent code would try to query these dictionaries to build up the unescaped Comment on attachment 383631 [details]
Patch
r=me
Created attachment 384639 [details]
To land
Committed r252991: <https://trac.webkit.org/changeset/252991> |