Bug 204236

Summary: REGRESSION (r195080): prepare-ChangeLog does not emit function list for file paths that contain a space
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 137982    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews214 for win-future
none
To land none

Daniel Bates
Reported 2019-11-15 11:17:19 PST
The fix for bug #137982 broke function list generation for file paths that contain space characters (e.g. Folder/Another Folder With Spaces/A.m).
Attachments
Patch (2.23 KB, patch)
2019-11-15 11:23 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews214 for win-future (14.31 MB, application/zip)
2019-11-15 15:06 PST, EWS Watchlist 		no flags
Details
To land (2.22 KB, patch)
2019-12-02 10:32 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-11-15 11:20:03 PST
Why did bug #137982 break things? I explained in bug 137982, comment 6.
Daniel Bates
Comment 2 2019-11-15 11:23:52 PST
Created attachment 383631 [details] Patch
EWS Watchlist
Comment 3 2019-11-15 15:06:01 PST
Comment on attachment 383631 [details] Patch Attachment 383631 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13259035 New failing tests: animations/no-style-recalc-during-accelerated-animation.html
EWS Watchlist
Comment 4 2019-11-15 15:06:04 PST
Created attachment 383655 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Daniel Bates
Comment 5 2019-12-02 10:14:13 PST
(In reply to Build Bot from comment #4) > Created attachment 383655 [details] > Archive of layout-test-results from ews214 for win-future > > The attached test failures were seen while running run-webkit-tests on the > win-ews. > Bot: ews214 Port: win-future Platform: > CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit ^^^ Ignore. Patch doesn't affect tests.
Daniel Bates
Comment 6 2019-12-02 10:15:58 PST
Comment on attachment 383631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383631&action=review > Tools/ChangeLog:11 > + the unescape file path. Subsequent code would try to query these dictionaries to build up the unescaped
Blaze Burg
Comment 7 2019-12-02 10:25:19 PST
Comment on attachment 383631 [details] Patch r=me
Daniel Bates
Comment 8 2019-12-02 10:32:21 PST
Created attachment 384639 [details] To land
Daniel Bates
Comment 9 2019-12-02 10:32:59 PST
Committed r252991: <https://trac.webkit.org/changeset/252991>
Radar WebKit Bug Importer
Comment 10 2019-12-02 10:33:23 PST
<rdar://problem/57562442>
Note You need to log in before you can comment on or make changes to this bug.