Bug 204234

Summary: Add more release logging for network load restarts
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2019-11-15 10:43:27 PST
Add more release logging for network load restarts.
Comment 1 Chris Dumez 2019-11-15 10:44:18 PST
Created attachment 383627 [details]
Patch
Comment 2 youenn fablet 2019-11-15 15:07:27 PST
Comment on attachment 383627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265
> +        RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(), m_parameters.identifier);

Isn’t it a bit redundant with serviceworkerfetchtask logging?
Comment 3 Chris Dumez 2019-11-15 15:14:07 PST
Comment on attachment 383627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265
>> +        RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(), m_parameters.identifier);
> 
> Isn’t it a bit redundant with serviceworkerfetchtask logging?

I really want to see the call sites of restartNetworkLoad().
Comment 4 youenn fablet 2019-11-15 15:23:41 PST
I believe this specific didNotHandle is logged twice, once in NetworkResouceLoader and once in ServiceWorkerFetchTask. If so, this seems excessive.
Comment 5 WebKit Commit Bot 2019-11-15 15:54:39 PST
Comment on attachment 383627 [details]
Patch

Clearing flags on attachment: 383627

Committed r252510: <https://trac.webkit.org/changeset/252510>
Comment 6 WebKit Commit Bot 2019-11-15 15:54:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-15 15:55:16 PST
<rdar://problem/57243555>