Bug 204234

Summary:

Add more release logging for network load restarts

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2019-11-15 10:43:27 PST

Add more release logging for network load restarts.

Attachments
Patch (3.53 KB, patch) 2019-11-15 10:44 PST, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-11-15 10:44:18 PST

Created attachment 383627 [details] Patch

youenn fablet

Comment 2 2019-11-15 15:07:27 PST

Comment on attachment 383627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265 > + RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(), m_parameters.identifier); Isn’t it a bit redundant with serviceworkerfetchtask logging?

Chris Dumez

Comment 3 2019-11-15 15:14:07 PST

Comment on attachment 383627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383627&action=review >> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:1265 >> + RELEASE_LOG_IF_ALLOWED("serviceWorkerDidNotHandle: (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ") Restarting network load", m_parameters.webPageID.toUInt64(), m_parameters.webFrameID.toUInt64(), m_parameters.identifier); > > Isn’t it a bit redundant with serviceworkerfetchtask logging? I really want to see the call sites of restartNetworkLoad().

youenn fablet

Comment 4 2019-11-15 15:23:41 PST

I believe this specific didNotHandle is logged twice, once in NetworkResouceLoader and once in ServiceWorkerFetchTask. If so, this seems excessive.

WebKit Commit Bot

Comment 5 2019-11-15 15:54:39 PST

Comment on attachment 383627 [details] Patch Clearing flags on attachment: 383627 Committed r252510: <https://trac.webkit.org/changeset/252510>

WebKit Commit Bot

Comment 6 2019-11-15 15:54:40 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-11-15 15:55:16 PST

<rdar://problem/57243555>

Note You need to log in before you can comment on or make changes to this bug.