Bug 204222

Summary: [ews] Perform validation of patch before retrying JSC tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203756
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-11-15 04:11:44 PST
JSC tests takes a while to run (~45 mins). In case of failure, we retry the tests, and if failures are noticed in retry as well, then we un-apply the patch, build the ToT and run the tests again. All these steps might take a while to complete. Meanwhile the patch might get obsolete or r-. EWS should not continue to process such patches, as it would be wasteful. We should check the patch status before running any time-consuming step (like running tests, or building without patch). We did similar thing for layout and api tests in https://trac.webkit.org/changeset/252037/webkit
Attachments
Patch (2.22 KB, patch)
2019-11-15 04:14 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-11-15 04:14:05 PST
Created attachment 383612 [details] Patch
WebKit Commit Bot
Comment 2 2019-11-15 08:39:32 PST
Comment on attachment 383612 [details] Patch Clearing flags on attachment: 383612 Committed r252485: <https://trac.webkit.org/changeset/252485>
WebKit Commit Bot
Comment 3 2019-11-15 08:39:33 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-11-15 08:40:20 PST
<rdar://problem/57228467>
Note You need to log in before you can comment on or make changes to this bug.