Bug 204220

Summary: Remove self-defined C++14 features in StdLibExtras.h
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Web Template FrameworkAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, don.olmstead, ews-watchlist, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews215 for win-future
none
Patch none

Fujii Hironori
Reported 2019-11-15 00:15:37 PST
Remove self-defined C++14 features in StdLibExtras.h Remove std::conjunction, std::in_place_t and std::make_unique.
Attachments
Patch (5.61 KB, patch)
2019-11-15 00:20 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews215 for win-future (14.55 MB, application/zip)
2019-11-15 03:06 PST, EWS Watchlist 		no flags
Details
Patch (4.45 KB, patch)
2019-11-17 19:43 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-11-15 00:20:33 PST
Created attachment 383605 [details] Patch
EWS Watchlist
Comment 2 2019-11-15 03:06:34 PST
Comment on attachment 383605 [details] Patch Attachment 383605 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13257973 New failing tests: js/math-clz32.html
EWS Watchlist
Comment 3 2019-11-15 03:06:37 PST
Created attachment 383611 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Fujii Hironori
Comment 4 2019-11-17 19:43:48 PST
Created attachment 383723 [details] Patch
Ross Kirsling
Comment 5 2019-11-18 09:24:08 PST
Comment on attachment 383723 [details] Patch EWS seems happy with it so r=me :)
WebKit Commit Bot
Comment 6 2019-11-18 14:48:13 PST
Comment on attachment 383723 [details] Patch Clearing flags on attachment: 383723 Committed r252596: <https://trac.webkit.org/changeset/252596>
WebKit Commit Bot
Comment 7 2019-11-18 14:48:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-11-18 14:49:23 PST
<rdar://problem/57299559>
Note You need to log in before you can comment on or make changes to this bug.