Bug 204220 - Remove self-defined C++14 features in StdLibExtras.h
Summary: Remove self-defined C++14 features in StdLibExtras.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-15 00:15 PST by Fujii Hironori
Modified: 2019-11-18 14:49 PST (History)
12 users (show)

See Also:

Attachments
Patch (5.61 KB, patch)
2019-11-15 00:20 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (14.55 MB, application/zip)
2019-11-15 03:06 PST, EWS Watchlist 		no flags Details
Patch (4.45 KB, patch)
2019-11-17 19:43 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-11-15 00:15:37 PST 
Remove self-defined C++14 features in StdLibExtras.h

Remove std::conjunction, std::in_place_t and std::make_unique.
Comment 1 Fujii Hironori 2019-11-15 00:20:33 PST 
Created attachment 383605 [details]
Patch
Comment 2 EWS Watchlist 2019-11-15 03:06:34 PST 
Comment on attachment 383605 [details]
Patch

Attachment 383605 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13257973

New failing tests:
js/math-clz32.html
Comment 3 EWS Watchlist 2019-11-15 03:06:37 PST 
Created attachment 383611 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Fujii Hironori 2019-11-17 19:43:48 PST 
Created attachment 383723 [details]
Patch
Comment 5 Ross Kirsling 2019-11-18 09:24:08 PST 
Comment on attachment 383723 [details]
Patch

EWS seems happy with it so r=me :)
Comment 6 WebKit Commit Bot 2019-11-18 14:48:13 PST 
Comment on attachment 383723 [details]
Patch

Clearing flags on attachment: 383723

Committed r252596: <https://trac.webkit.org/changeset/252596>
Comment 7 WebKit Commit Bot 2019-11-18 14:48:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-11-18 14:49:23 PST 
<rdar://problem/57299559>