Bug 204207

Summary: Publish JavaScriptCore as Clang module
Product: WebKit Reporter: Chris Polcyn <cpolcyn>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Polcyn
Reported 2019-11-14 16:04:37 PST
Publish JavaScriptCore as Clang module
Attachments
Patch (1.09 KB, patch)
2019-11-14 16:10 PST, Chris Polcyn 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Polcyn
Comment 1 2019-11-14 16:10:47 PST
Created attachment 383582 [details] Patch
Keith Miller
Comment 2 2019-11-14 16:36:19 PST
Do Clang modules support exporting macros? I'm assuming yes but, IIRC, C++ modules don't.
Chris Polcyn
Comment 3 2019-11-14 20:23:24 PST
(In reply to Keith Miller from comment #2) > Do Clang modules support exporting macros? I'm assuming yes but, IIRC, C++ > modules don't. Yes, you can read about it here: https://clang.llvm.org/docs/Modules.html#macros
Keith Miller
Comment 4 2019-11-14 22:11:41 PST
Comment on attachment 383582 [details] Patch I see, that makes sense. r=me.
Keith Miller
Comment 5 2019-11-14 22:12:52 PST
Do you have commit privileges? If not, I can do it for you.
Chris Polcyn
Comment 6 2019-11-18 09:52:46 PST
(In reply to Keith Miller from comment #5) > Do you have commit privileges? If not, I can do it for you. I assume I don't have commit privileges as it's my first time contributing here. If you want to do it that would be great. Thanks!
WebKit Commit Bot
Comment 7 2019-11-18 10:55:26 PST
Comment on attachment 383582 [details] Patch Clearing flags on attachment: 383582 Committed r252551: <https://trac.webkit.org/changeset/252551>
WebKit Commit Bot
Comment 8 2019-11-18 10:55:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-11-18 10:56:17 PST
<rdar://problem/57289332>
Note You need to log in before you can comment on or make changes to this bug.