Bug 204188

Summary: [Cocoa] Add ui-sans-serif as a sibling to ui-serif, ui-monospace, and ui-rounded
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jonlee, mjs, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Myles C. Maxfield 2019-11-13 19:51:59 PST 
[Cocoa] Add ui-sans-serif as a sibling to ui-serif, ui-monospace, and ui-rounded
Comment 1 Myles C. Maxfield 2019-11-13 19:53:41 PST 
Created attachment 383536 [details]
Patch
Comment 2 Myles C. Maxfield 2019-11-14 11:29:34 PST 
Created attachment 383563 [details]
Patch
Comment 3 Myles C. Maxfield 2019-11-14 11:30:52 PST 
Created attachment 383564 [details]
Patch
Comment 4 Myles C. Maxfield 2019-11-19 19:19:59 PST 
The test failures look unrelated.
Comment 5 Simon Fraser (smfr) 2019-11-19 19:52:17 PST 
Comment on attachment 383564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383564&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1272
>      Optional<SystemFontDatabaseCoreText::ClientUse> designSystemUI;

These words don't tell me anything. "client use"? "design system UI" - is that a job title?
Comment 6 Myles C. Maxfield 2019-11-20 13:19:22 PST 
(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 383564 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383564&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1272
> >      Optional<SystemFontDatabaseCoreText::ClientUse> designSystemUI;
> 
> These words don't tell me anything. "client use"? "design system UI" - is
> that a job title?

"system design" is a term of art: https://developer.apple.com/documentation/appkit/nsfontdescriptorsystemdesign?language=objc

I suppose I could rename "design system ui" to "system design."

I guess I could rename "client use" to "use case." Or maybe "purpose?" Or maybe "family?" 🤔
Comment 7 Myles C. Maxfield 2019-11-20 13:20:50 PST 
(In reply to Myles C. Maxfield from comment #6)
> (In reply to Simon Fraser (smfr) from comment #5)
> > Comment on attachment 383564 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=383564&action=review
> > 
> > > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1272
> > >      Optional<SystemFontDatabaseCoreText::ClientUse> designSystemUI;
> > 
> > These words don't tell me anything. "client use"? "design system UI" - is
> > that a job title?
> 
> "system design" is a term of art:
> https://developer.apple.com/documentation/appkit/
> nsfontdescriptorsystemdesign?language=objc
> 
> I suppose I could rename "design system ui" to "system design."
> 
> I guess I could rename "client use" to "use case." Or maybe "purpose?" Or
> maybe "family?" 🤔

These renames will end up being a bigger patch than this patch here, so I'll do that in a follow-up patch.
Comment 8 WebKit Commit Bot 2019-11-20 14:29:51 PST 
Comment on attachment 383564 [details]
Patch

Clearing flags on attachment: 383564

Committed r252710: <https://trac.webkit.org/changeset/252710>
Comment 9 WebKit Commit Bot 2019-11-20 14:29:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-11-20 14:30:26 PST 
<rdar://problem/57373054>
Comment 11 Myles C. Maxfield 2019-11-21 19:22:32 PST 
(In reply to Myles C. Maxfield from comment #7)
> (In reply to Myles C. Maxfield from comment #6)
> > (In reply to Simon Fraser (smfr) from comment #5)
> > > Comment on attachment 383564 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=383564&action=review
> > > 
> > > > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1272
> > > >      Optional<SystemFontDatabaseCoreText::ClientUse> designSystemUI;
> > > 
> > > These words don't tell me anything. "client use"? "design system UI" - is
> > > that a job title?
> > 
> > "system design" is a term of art:
> > https://developer.apple.com/documentation/appkit/
> > nsfontdescriptorsystemdesign?language=objc
> > 
> > I suppose I could rename "design system ui" to "system design."
> > 
> > I guess I could rename "client use" to "use case." Or maybe "purpose?" Or
> > maybe "family?" 🤔
> 
> These renames will end up being a bigger patch than this patch here, so I'll
> do that in a follow-up patch.

https://bugs.webkit.org/show_bug.cgi?id=204486