Bug 204146

Summary: [Win][DumpRenderTree][WebKitTestRunner] eventSender.keyDown should support function keys
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, don.olmstead, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Fujii Hironori
Reported 2019-11-13 01:10:31 PST
[Win][DumpRenderTree][WebKitTestRunner] eventSender.keyDown should support function keys fast/events/keydown-function-keys.html is failing for AppleWin and WinCairo ports.
Attachments
Patch (16.40 KB, patch)
2019-11-13 01:44 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.80 KB, patch)
2019-11-13 17:52 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-11-13 01:44:21 PST
Created attachment 383440 [details] Patch
Fujii Hironori
Comment 2 2019-11-13 03:41:15 PST
Comment on attachment 383440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383440&action=review > Tools/DumpRenderTree/win/EventSender.cpp:465 > + // Some keys need to turn on KF_EXTENDED explicitly This is a hack to work around a bug of MapVirtualKey and MapVirtualKeyEx doesn't work as expected. MapVirtualKey(), GetKeyNameText(), and a story of how to get proper names for the arrow keys - setnode.com http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/ http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/#comment-1104594462 > Even using MapVirtualKeyEx() doesn't make MAPVK_VK_TO_VSC_EX behave the way the docs seem to imply.
Ross Kirsling
Comment 3 2019-11-13 15:18:39 PST
Comment on attachment 383440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383440&action=review r=me >> Tools/DumpRenderTree/win/EventSender.cpp:465 >> + // Some keys need to turn on KF_EXTENDED explicitly > > This is a hack to work around a bug of MapVirtualKey and MapVirtualKeyEx doesn't work as expected. > > MapVirtualKey(), GetKeyNameText(), and a story of how to get proper names for the arrow keys - setnode.com > http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/ > > http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/#comment-1104594462 Perhaps this info should be added to the ChangeLog?
Fujii Hironori
Comment 4 2019-11-13 17:33:16 PST
Comment on attachment 383440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383440&action=review >>> Tools/DumpRenderTree/win/EventSender.cpp:465 >>> + // Some keys need to turn on KF_EXTENDED explicitly >> >> This is a hack to work around a bug of MapVirtualKey and MapVirtualKeyEx doesn't work as expected. >> >> MapVirtualKey(), GetKeyNameText(), and a story of how to get proper names for the arrow keys - setnode.com >> http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/ >> >> http://www.setnode.com/blog/mapvirtualkey-getkeynametext-and-a-story-of-how-to/#comment-1104594462 > > Perhaps this info should be added to the ChangeLog? Will do.
Fujii Hironori
Comment 5 2019-11-13 17:52:17 PST
Created attachment 383531 [details] Patch for landing
Fujii Hironori
Comment 6 2019-11-13 17:56:06 PST
Committed r252441: <https://trac.webkit.org/changeset/252441>
Radar WebKit Bug Importer
Comment 7 2019-11-13 17:57:54 PST
<rdar://problem/57176065>
Note You need to log in before you can comment on or make changes to this bug.