Summary: | Cleanup old UIKit Staging | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, dino, thorton, webkit-bug-importer, wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Megan Gardner
2019-11-12 16:22:36 PST
Created attachment 383401 [details]
Patch
Comment on attachment 383401 [details] Patch Clearing flags on attachment: 383401 Committed r252434: <https://trac.webkit.org/changeset/252434> All reviewed patches have been landed. Closing bug. Comment on attachment 383401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383401&action=review > Source/WebKit/Platform/spi/ios/UIKitSPI.h:-1112 > -@interface UIWebGeolocationPolicyDecider (Staging_25963823) > -- (void)decidePolicyForGeolocationRequestFromOrigin:(id)securityOrigin requestingURL:(NSURL *)requestingURL view:(UIView *)view listener:(id)listener; > -@end Roy pointed out that this broke internal build. This declaration is now only compiled in open source builds - and this method doesn't actually exist. Code that uses this variant of decidePolicyForGeolocationRequestFromOrigin has a respondsToSelector check, so it is dead code. May be some kind of mistake in the patch that added this, rolling back for now. Ugh, there were a lot of patches touching this header later, all of which would have to be rolled back. Attempted a build fix in http://trac.webkit.org/r252535 - but someone (i.e. thorton) needs to take a look at what the intent of this code was originally. No, I see what happened better now. Trying a different build fix in http://trac.webkit.org/r252536. |