| Summary: | Update unit-tests for JSC EWS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=201997 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-11-12 12:36:48 PST
Created attachment 383371 [details]
Patch
Comment on attachment 383371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383371&action=review > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:-1075 > - self.expectRemoteCommands( Why are we removing this? Comment on attachment 383371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383371&action=review >> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:-1075 >> - self.expectRemoteCommands( > > Why are we removing this? We are removing this class and newer version of this class now sub-classes from TestRunJavaScriptCoreTests. So it automatically runs all the unit-tests run by TestRunJavaScriptCoreTests. That way we won't have to duplicate all the unit-test from TestRunJavaScriptCoreTests into TestReRunJavaScriptCoreTests. Similar to TestRunWebKitTestsWithoutPatch at https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py#L1307 Committed r252375: <https://trac.webkit.org/changeset/252375> |