RESOLVED FIXED204123
Update unit-tests for JSC EWS 
https://bugs.webkit.org/show_bug.cgi?id=204123
Summary Update unit-tests for JSC EWS
Aakash Jain
Reported 2019-11-12 12:36:48 PST
After we updated platform from 'jsc-only' to 'mac-highsierra' for jsc queues in https://trac.webkit.org/changeset/250102/webkit, we need to update the unit-tests to correctly cover both 'mac-highsierra' and 'jsc-only' platforms.
Attachments
Patch (6.00 KB, patch)
2019-11-12 12:51 PST, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-11-12 12:51:53 PST
Created attachment 383371 [details] Patch
Jonathan Bedard
Comment 2 2019-11-12 13:26:40 PST
Comment on attachment 383371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383371&action=review > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:-1075 > - self.expectRemoteCommands( Why are we removing this?
Aakash Jain
Comment 3 2019-11-12 13:34:13 PST
Comment on attachment 383371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383371&action=review >> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:-1075 >> - self.expectRemoteCommands( > > Why are we removing this? We are removing this class and newer version of this class now sub-classes from TestRunJavaScriptCoreTests. So it automatically runs all the unit-tests run by TestRunJavaScriptCoreTests. That way we won't have to duplicate all the unit-test from TestRunJavaScriptCoreTests into TestReRunJavaScriptCoreTests. Similar to TestRunWebKitTestsWithoutPatch at https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py#L1307
Aakash Jain
Comment 4 2019-11-12 15:04:39 PST
Committed r252375: <https://trac.webkit.org/changeset/252375>
Radar WebKit Bug Importer
Comment 5 2019-11-12 15:05:59 PST
<rdar://problem/57132571>
Note You need to log in before you can comment on or make changes to this bug.