Bug 204123 - Update unit-tests for JSC EWS
Summary: Update unit-tests for JSC EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-12 12:36 PST by Aakash Jain
Modified: 2019-11-12 15:05 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.00 KB, patch)
2019-11-12 12:51 PST, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-12 12:36:48 PST
After we updated platform from 'jsc-only' to 'mac-highsierra' for jsc queues in https://trac.webkit.org/changeset/250102/webkit, we need to update the unit-tests to correctly cover both 'mac-highsierra' and 'jsc-only' platforms.
Comment 1 Aakash Jain 2019-11-12 12:51:53 PST
Created attachment 383371 [details]
Patch
Comment 2 Jonathan Bedard 2019-11-12 13:26:40 PST
Comment on attachment 383371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383371&action=review

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:-1075
> -        self.expectRemoteCommands(

Why are we removing this?
Comment 3 Aakash Jain 2019-11-12 13:34:13 PST
Comment on attachment 383371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383371&action=review

>> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:-1075
>> -        self.expectRemoteCommands(
> 
> Why are we removing this?

We are removing this class and newer version of this class now sub-classes from TestRunJavaScriptCoreTests. So it automatically runs all the unit-tests run by TestRunJavaScriptCoreTests. That way we won't have to duplicate all the unit-test from TestRunJavaScriptCoreTests into TestReRunJavaScriptCoreTests.

Similar to TestRunWebKitTestsWithoutPatch at https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py#L1307
Comment 4 Aakash Jain 2019-11-12 15:04:39 PST
Committed r252375: <https://trac.webkit.org/changeset/252375>
Comment 5 Radar WebKit Bug Importer 2019-11-12 15:05:59 PST
<rdar://problem/57132571>