Bug 204122

Summary: Use toLength() and getIndexQuickly() in JSON.stringify
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203227
Attachments:
Description Flags
Patch none

Description Alexey Shvayka 2019-11-12 12:02:12 PST 
Use toLength() and getIndexQuickly() in JSON.stringify
Comment 1 Alexey Shvayka 2019-11-12 12:23:56 PST 
Created attachment 383370 [details]
Patch
Comment 2 Alexey Shvayka 2019-11-12 12:51:11 PST 
Style EWS fails because of

  RETURN_IF_EXCEPTION(scope, ); // <= that space,

which is a common pattern.

Cold runs, only results with low measurement error, --outer 8:

                                      rev. 252354             patch

json-stringify-array-replacer      350.7169+-0.9911      263.3854+-2.2296
json-stringify-empty-array         188.0573+-1.2934      189.5053+-1.4060
Comment 3 Yusuke Suzuki 2019-11-14 13:15:39 PST 
Comment on attachment 383370 [details]
Patch

Nice, r=me
Comment 4 WebKit Commit Bot 2019-11-14 14:00:06 PST 
Comment on attachment 383370 [details]
Patch

Clearing flags on attachment: 383370

Committed r252464: <https://trac.webkit.org/changeset/252464>
Comment 5 WebKit Commit Bot 2019-11-14 14:00:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-14 14:01:25 PST 
<rdar://problem/57203266>