Bug 204085

Summary:

Web Inspector: "aqua" and "fuchsia" aren't detected as colors

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	hi: review+
Patch	none

Description Nikita Vasilyev 2019-11-11 14:50:30 PST

That's the only color keyword that is defined in https://www.w3.org/TR/css-color-4/#named-colors
but missing in the Web Inpector color dictionary.

Comment 1 Nikita Vasilyev 2019-11-11 14:51:19 PST

Created attachment 383303 [details]
Patch

Comment 2 Devin Rousso 2019-11-13 10:29:48 PST

Comment on attachment 383303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383303&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Color.js:745
> +    "aqua": [0, 255, 255, 1],

We're also missing `fuchsia`, which is one of the original HTML colors 🤦‍♂️:
```
    "fuchsia": [255, 0, 255, 1],
```

Interestingly, both `aqua` and `fuchsia` have alternate names in CSS, respectively being `cyan` and `magenta`.

This doesn't look to be an issue, other than that we'll instead always prefer `aqua` over `cyan` (same with `fuchsia` over `magenta`) when generating CSS color keyword strings simply because they're sorted alphabetically.

Comment 3 Nikita Vasilyev 2019-11-13 13:41:48 PST

Created attachment 383489 [details]
Patch

Comment 4 WebKit Commit Bot 2019-11-13 20:04:23 PST

Comment on attachment 383489 [details]
Patch

Clearing flags on attachment: 383489

Committed r252448: <https://trac.webkit.org/changeset/252448>

Comment 5 WebKit Commit Bot 2019-11-13 20:04:25 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2019-11-13 20:05:22 PST

<rdar://problem/57178710>