Bug 204071

Summary: [EWS] Use named arguments in factories.py
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, pmatos, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-11-11 08:38:39 PST
We should use named arguments in factories.py. It's much more clear, and less error-prone.
Attachments
Patch (9.76 KB, patch)
2019-11-11 08:42 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-11-11 08:42:22 PST
Created attachment 383272 [details] Patch
Jonathan Bedard
Comment 2 2019-11-11 08:44:19 PST
Comment on attachment 383272 [details] Patch I think I actually complained about this in a patch a few months ago...
WebKit Commit Bot
Comment 3 2019-11-11 09:49:24 PST
Comment on attachment 383272 [details] Patch Clearing flags on attachment: 383272 Committed r252329: <https://trac.webkit.org/changeset/252329>
WebKit Commit Bot
Comment 4 2019-11-11 09:49:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-11-11 16:50:04 PST
<rdar://problem/57099069>
Note You need to log in before you can comment on or make changes to this bug.