Bug 204069

Summary: OverConstrainedError is missing 'name' property
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Eric Carlson
Reported 2019-11-11 07:40:51 PST
OverconstrainedError.name returns "Error", but spec says: The initial value of the name property of the prototype for the OverconstrainedError constructor is "OverconstrainedError". https://w3c.github.io/mediacapture-main/#overconstrainederror-prototype-name
Attachments
Patch (7.93 KB, patch)
2019-11-18 11:05 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (9.42 KB, patch)
2019-11-19 05:40 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2019-11-18 11:05:07 PST
Created attachment 383763 [details] Patch
youenn fablet
Comment 2 2019-11-18 17:02:18 PST
Comment on attachment 383763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383763&action=review > Source/WebCore/ChangeLog:8 > + No new tests, existing test and results updated. There is one failing test on Mac that probably needs to get updated. > LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/GUM-impossible-constraint.https-expected.txt:8 > +FAIL Tests that setting an impossible constraint in getUserMedia fails assert_equals: The name of the not satisfied error is given in error.constraint expected "width" but got "" We should look at these tests, maybe we should update them since we are not exposing the constraint if device info is not granted.
Eric Carlson
Comment 3 2019-11-19 05:40:06 PST
Created attachment 383861 [details] Patch
WebKit Commit Bot
Comment 4 2019-11-19 08:51:03 PST
Comment on attachment 383861 [details] Patch Clearing flags on attachment: 383861 Committed r252632: <https://trac.webkit.org/changeset/252632>
WebKit Commit Bot
Comment 5 2019-11-19 08:51:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-11-19 08:52:22 PST
<rdar://problem/57323357>
Note You need to log in before you can comment on or make changes to this bug.