Bug 204063

Summary: [GTK] Add 'test262-test' step to GTK and WPE build bots
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, clopez, commit-queue, ews-watchlist, guijemont, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204154
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Diego Pino
Reported 2019-11-11 02:00:13 PST
[GTK] Add 'test262-test' to GTK and JSCOnly build bots
Attachments
Patch (6.92 KB, patch)
2019-11-11 02:00 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (7.97 KB, patch)
2019-11-11 07:52 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (8.34 KB, patch)
2019-11-11 09:43 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (8.39 KB, patch)
2019-11-12 06:15 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2019-11-11 02:00:51 PST
Created attachment 383256 [details] Patch
Diego Pino
Comment 2 2019-11-11 07:52:52 PST
Created attachment 383269 [details] Patch
Carlos Alberto Lopez Perez
Comment 3 2019-11-11 08:36:43 PST
Comment on attachment 383269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383269&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:111 > if platform == "gtk": > self.addStep(RunGtkAPITests()) > self.addStep(RunWebDriverTests()) > + self.addStep(RunTest262Tests()) > if platform == "wpe": > self.addStep(RunWPEAPITests()) We likely want to run it also on the WPE bots. > Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:149 > + self.addStep(RunTest262Tests(timeout=60 * 60)) Does this script support running remotely? If not then we can't run it on the JSCOnly buildbots that run remote JSC tests
Diego Pino
Comment 4 2019-11-11 09:43:26 PST
Created attachment 383277 [details] Patch
Carlos Alberto Lopez Perez
Comment 5 2019-11-11 09:54:50 PST
Comment on attachment 383277 [details] Patch r=me.
WebKit Commit Bot
Comment 6 2019-11-12 06:11:35 PST
Comment on attachment 383277 [details] Patch Rejecting attachment 383277 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 383277, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/13242490
Diego Pino
Comment 7 2019-11-12 06:15:00 PST
Created attachment 383350 [details] Patch
WebKit Commit Bot
Comment 8 2019-11-12 07:07:29 PST
Comment on attachment 383350 [details] Patch Clearing flags on attachment: 383350 Committed r252362: <https://trac.webkit.org/changeset/252362>
WebKit Commit Bot
Comment 9 2019-11-12 07:07:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-11-12 07:08:17 PST
<rdar://problem/57115334>
Note You need to log in before you can comment on or make changes to this bug.